mshop/price/taxflag set to 0, VAT not added to total

Help for integrating the Laravel package
Forum rules
Always add your Laravel, Aimeos and PHP version as well as your environment (Linux/Mac/Win)
Spam and unrelated posts will be removed immediately!
nos3
Posts: 87
Joined: 01 Sep 2015, 13:26

Re: mshop/price/taxflag set to 0, VAT not added to total

Post by nos3 » 08 Jul 2019, 16:06

Hey

We are still testing the new Aimeos 2019.07 release ourselves, especially in combination with our own extensions because from 2019.04 to 2019.07, there has been a big change regarding tax handling as there are multiple tax rates per price now instead of only one.

We try to reproduce your behavior and come back to you as soon as possible.

Best regards,


Norbert

User avatar
aimeos
Administrator
Posts: 7866
Joined: 01 Jan 1970, 00:00

Re: mshop/price/taxflag set to 0, VAT not added to total

Post by aimeos » 08 Jul 2019, 16:59

The 2019.07.x-dev branch now contains two more fixes. The first one is for the image sizing (bundled products, requires new CSS file). The second one is for the missing shipping costs in the summary. That was due to a missing new variable that hasn't been passed to the partial.

Sorry for your inconvenience as the first one testing the brand new release in real live. Seems like we are relying too much on our unit tests which doesn't cover the HTML frontend totally :-(
Professional support and custom implementation are available at Aimeos.com
If you like Aimeos, Image give us a star

User avatar
aimeos
Administrator
Posts: 7866
Joined: 01 Jan 1970, 00:00

Re: Image sizing and positioning

Post by aimeos » 09 Jul 2019, 09:50

These CSS styles are responsible for centering the images regardless of their size:
- https://github.com/aimeos/ai-client-htm ... #L860-L891
- https://github.com/aimeos/ai-client-htm ... 1784-L1832

The images are scaled according to the config settings to create several responsive image sizes:
https://github.com/aimeos/aimeos-core/b ... er.php#L31
The different image sizes are then used in the "srcset" attribute and the browser selects the image it thinks fits best.
Professional support and custom implementation are available at Aimeos.com
If you like Aimeos, Image give us a star

nos3
Posts: 87
Joined: 01 Sep 2015, 13:26

Re: mshop/price/taxflag set to 0, VAT not added to total

Post by nos3 » 09 Jul 2019, 11:37

Hi Sacha
sacha_smz wrote: 08 Jul 2019, 18:37 Remains also the 2,40€ of VAT
EDIT: 2.40 € was not arbitrary, it is the tax on shipping
We couldn't reproduce that issue in our environment. Thus, we need a few things:
- Does it only occur with ai-vatcheck extension installed or also without?
- A screenshot of the checkout summary page including the basket details
- A screenshot from the service detail -> price panel of your selected shipping option
- A screenshot of your AddVat plugin configuration

Before you start, please clear your cookies so there's nothing in your browser session left.

BTW: If you update the ai-vatcheck extension (2019.07.x-dev) you can now use the "*" in the addvat.never field of the AddVat plugin configuration. That makes more sense than for addvat.always

Best regards


Norbert

nos3
Posts: 87
Joined: 01 Sep 2015, 13:26

Re: mshop/price/taxflag set to 0, VAT not added to total

Post by nos3 » 10 Jul 2019, 19:54

Hello Sacha

Thank you for the screenshots, everything seems to look normal and yes, same tax for products and shipping applies if both have the same tax rate.

Our test installation behaves correctly for that cases so we would need some more help from your side. Here's a list of critical lines of code which you can check:

There's only output in the template if the tax value is greater than 0 (which seems to be the case):
https://github.com/aimeos/ai-client-htm ... d.php#L368

The prices for taxing are summed up in this method:
https://github.com/aimeos/ai-client-htm ... se.php#L90

If "$this->setModified()" is called here, then the tax value is reset:
https://github.com/aimeos/aimeos-core/b ... d.php#L341

Tax value is finally calculated there:
https://github.com/aimeos/aimeos-core/b ... d.php#L414

Another thing to check in your database is if the taxrate column only contain values like this one:

Code: Select all

{"":"20.00"}
Best regards,


Norbert

Post Reply