Wrong price send to payment provider when using NoVat?

[danielsiepmann]

We updated a customer project using the paid aimeoscom/ai-vatcheck package from 2021.04 to 2025.04.3.

It looks like there was some internal refactoring within aimeos regarding the recalculation logic of the basket/invoice price.
The packege called

Code: Select all

$basket->setModified()

in the past. It now misses any call leading to no properly applying the NoVat logic to the final price send to the payment provider.

We could fix it by adding the following line instead:

Code: Select all

$basket->getPrice()->setModified();

I'm not 100% sure I got everything right. So it would be cool to know if this fix is correct or what we should do instead.
I'd opened an issue instead of this help post, but get a 404 as the source code, for obvious reasons, is not public.

[nos3]

Hi Daniel

It looks like there was some internal refactoring within aimeos regarding the recalculation logic of the basket/invoice price.
The packege called

Code: Select all

$basket->setModified()

in the past. It now misses any call leading to no properly applying the NoVat logic to the final price send to the payment provider.

We could fix it by adding the following line instead:

Code: Select all

$basket->getPrice()->setModified();

Using $basket->getPrice()->setModified() looks good to me. Where is that missing in the 2025.10 version?