Payment email exception for payed orders

[Moritz]

I found it.
In the execute function you call self::context($tsconf, $pid) before $context->config()->apply($conf).

scheduler_execute.png (30.09 KiB) Viewed 12551 times

But in self::context($tsconf, $pid) the view is already created with the old config of the context.

create_view.png (32.27 KiB) Viewed 12551 times

Maybe it's enough to swap the two lines or does that affect the rest of the code?

[aimeos]

You can't swap the two lines but maybe it's enough to swap $conf and $tsconf variables.

[Moritz]

You're right, I've written faster than thinking

You can't swap the two lines but maybe it's enough to swap $conf and $tsconf variables.

I don't know if that works.
Inside the context function you use i18n from $tsconf.
https://github.com/aimeos/aimeos-typo3/ ... se.php#L97

[aimeos]

Maybe using apply for both config arrays works better:

Code: Select all

$context->config()->apply($conf)->apply($tsconfig);

[Moritz]

You mean here after creating the $context https://github.com/aimeos/aimeos-typo3/ ... se.php#L79 ?
Because the context() function requires the config as parameter.

[aimeos]

Yes, because you can pass the $tsconf variable to the context() method nevertheless.

[Moritz]

Then I think that is the possible solution?

apply_config.png (15.71 KiB) Viewed 12527 times

[aimeos]

Yes, if it works?

[Moritz]

It works!
Should I create a pull request?

[aimeos]

Yes, please!